Tej Chajed authored 4 years ago and Ralf Jung committed 4 years ago

The syntax re-uses the existing support for pure names, namely the % and
%H patterns. Using "[% H]" is like `iDestruct ... as (?) "H"` and using
"[%x H]" (with the string-ident plugin) is like `iDestruct ... as (x)
"H"`.

This changes how these patterns are parsed. Previously, both would have
been handled as conjunctions (using IntoAnd or IntoSep, depending on
whether the hypothesis is persistent or not). This means it was possible
for the user to use "[% H]" to destruct a pure hypothesis ⌜φ ∧ ψ⌝ and
put only the first conjunct in the Gallina context, leaving the other
one in the IPM; such patterns will now break, since iExistDestruct
does not handle this use case.

Tej Chajed authored 4 years ago and Ralf Jung committed 4 years ago

Fixes #404

create iris-deprecated and iris-staging packages, and deprecate some hard-to-use logic-level wrappers as well as view shift and Hoare triple notation

Fixes #401

that performs `wp_pure` in small steps until the lemma matches the goal.

Done with a script by Tej; see
iris/iris!609 for details.

This is an alternative to !591.

This reverts merge request !591

Tej Chajed authored 4 years ago and Robbert Krebbers committed 4 years ago

`iDestruct ("H" with "HP")` where "H" is persistent is supposed to
consume "H" if it isn't a forall. Due to a bug in the tactic, this
behavior was never triggered and "H" was always left alone.

This test is incompatible with Coq 8.8 and Coq 8.9, but Iris no longer
supports those versions.