Skip to content
Snippets Groups Projects

Some refactor in Radium crate

Merged Some refactor in Radium crate
radium-refactor into main
Merged Vincent Lafeychine requested to merge radium-refactor into main

This refactor should go through many small steps to make sure that the whole process is merged.

In this branch, multiple attempt and proof-of-concept has been done:

  • Use derive_more for Display for no-or-few logic fmt functions
  • Use indoc for bigger blocks
  • Use radium to do the .to_string() logic

In addition, the overall process is to make the radium crate with almost no dependencies to other RefinedRust crates, and to make it as small as possible, since radium should only contain logic for the Coq proof assistant:

  • A RefCell<Option<T>> from radium changed to a simpler type, and the logic is now reflected by a OnceCell in translation:
    • Done with AbstractStructUse: RefCell<Option<AbstractStruct>> to Option<AbstractStruct>
    • Done with AbstractEnumUse: RefCell<Option<AbstractEnum>> to AbstractEnum
  • The dependency of rrconfig got removed
Edited by Vincent Lafeychine

Merge request reports

Pipeline #101392 passed

Stage: nix-cache
    Stage: lint
      Stage: build
        Stage: tests

          Pipeline passed for d3b06f9e on radium-refactor

          Approval is optional

          Merged by Lennard GäherLennard Gäher 9 months ago (May 22, 2024 6:34pm UTC)

          Merge details

          • Changes merged into with d3b06f9e.
          • Deleted the source branch.
          • Auto-merge enabled

          Pipeline #102133 passed

          Stage: nix-cache
            Stage: lint
              Stage: build
                Stage: tests

                  Pipeline passed for d3b06f9e on main

                  Activity

                  Filter activity
                  • Approvals
                  • Assignees & reviewers
                  • Comments (from bots)
                  • Comments (from users)
                  • Commits & branches
                  • Edits
                  • Labels
                  • Lock status
                  • Mentions
                  • Merge request status
                  • Tracking
                  Please register or sign in to reply