Skip to content
Snippets Groups Projects

Better use of modules / less global polution for strings

Merged Robbert Krebbers requested to merge robbert/string_notation into master
All threads resolved!

See CHANGELOG for details

Merge request reports

Merge request pipeline #106865 passed

Merge request pipeline passed for 1dd6bcab

Merged by Robbert KrebbersRobbert Krebbers 7 months ago (Sep 10, 2024 6:01pm UTC)

Loading

Pipeline #106866 passed

Pipeline passed for bc76f1d5 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ralf Jung
  • Ralf Jung
  • Ralf Jung
  • added 1 commit

    • 28d71c3c - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • added 8 commits

    Compare with previous version

  • Robbert Krebbers resolved all threads

    resolved all threads

  • I think I addressed all your comments.

  • Ralf Jung
  • LGTM with the final changelog nit (we used the arrow in past changelogs and I think it makes this fairly easy to scan).

  • Robbert Krebbers resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • Robbert Krebbers enabled an automatic merge when the pipeline for 1dd6bcab succeeds

    enabled an automatic merge when the pipeline for 1dd6bcab succeeds

  • mentioned in commit bc76f1d5

  • @iris-users This is a breaking change:

    • Move all definitions and lemmas about strings/ascii into the modules String/Ascii, i.e., rename string_rev_appString.rev_app, string_revString.rev, is_natAscii.is_nat, is_spaceAscii.is_space and wordsString.words.
    • The file std.strings no longer exports the String module, it only exports the string type, its constructors, induction principles, and notations (in string_scope). Similar to the number types (nat, N, Z), importing the String module yourself is discouraged, rather use

    The sed script will help you port your development.

  • Please register or sign in to reply
    Loading