Skip to content
Snippets Groups Projects

Rename `X_length` into `length_X`.

Merged Robbert Krebbers requested to merge robbert/length_X into master
All threads resolved!

This follows https://github.com/coq/coq/pull/18564 This closes #213 (closed)

We didn't include our own copies of app_length and seq_length, but used those from the standard library. To make sure we can use them (without deprecation warnings) until support for Coq 8.19 is dropped, I included our own copies for the transition period. This was also suggested by @tchajed in #213 (closed).

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ralf Jung
  • No objection from my side, just some nits.

  • This seems great to me. It's a lot of churn in naming but this inconsistency has always bothered me; I use some of these lemmas so much (especially the lemma formerly known as app_length) it can be hard to remember what the standard convention even is.

  • added 1 commit

    Compare with previous version

  • Ralf Jung
  • LGTM, feel free to land with the comments tweaked and whenever you have the time to fix reverse dependencies.

  • added 1 commit

    Compare with previous version

  • Robbert Krebbers resolved all threads

    resolved all threads

  • mentioned in commit 6190d85d

  • @iris-users This is a breaking change

  • Please register or sign in to reply
    Loading