Skip to content
Snippets Groups Projects

Use gmake for BSD systems

Merged Yiyun Liu requested to merge yiyunliu/stdpp:bsd-fix into master
1 unresolved thread

This PR modifies the make-package script so it runs on systems whose default make executable is BSD Make rather than GNU Make. It checks the os type and decides whether to run gmake or make. This is exactly how opam determines which make executable to use.

I also changed the script to use sh instead of bash because make-package doesn't seem to depend on bash-specific features and sh has a more standard path.

Merge request reports

Merge request pipeline #104575 passed

Merge request pipeline passed for c5e98d55

Approval is optional

Merged by Ralf JungRalf Jung 10 months ago (Jul 30, 2024 8:26am UTC)

Merge details

  • Changes merged into master with f2a1f915.
  • Did not delete the source branch.

Pipeline #104598 passed

Pipeline passed for f2a1f915 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ralf Jung
  • Yiyun Liu added 1 commit

    added 1 commit

    • c5e98d55 - Apply 1 suggestion(s) to 1 file(s)

    Compare with previous version

  • Ralf Jung resolved all threads

    resolved all threads

  • Thanks for the MR!

  • Ralf Jung mentioned in commit f2a1f915

    mentioned in commit f2a1f915

  • merged

  • I have added this to the changelog as well.

  • Yiyun Liu mentioned in merge request iris!1061 (merged)

    mentioned in merge request iris!1061 (merged)

  • Please register or sign in to reply
    Loading