Skip to content
Snippets Groups Projects

Provide "lookup" and "commuting" lemmas that handle "eq" and "ne" case in a single statement.

Merged Robbert Krebbers requested to merge robbert/eq_lemmas into ci/refactor_staging

This has been discussed in !507 (closed). This MR changes all lemmas for list, map, multiset in std++ according to that plan. The CHANGELOG describes all changes.

While performing the refactoring, I also added some missing lemmas. They are also described in the CHANGELOG.

I tested the sed script on iris, iris-examples, lambdarust, Actris, Iron, GPFSL. No manual fixes were needed.

Merge request reports

Merge request pipeline #91376 passed

Merge request pipeline passed for 0a52e84c

Approval is optional

Merged by Robbert KrebbersRobbert Krebbers 1 year ago (Oct 17, 2023 12:01pm UTC)

Merge details

  • Changes merged into ci/refactor_staging with fead4470.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #91377 passed

Pipeline passed for fead4470 on ci/refactor_staging

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ralf Jung
  • Ralf Jung
  • Ralf Jung
  • Wow that's a huge PR. Thanks a lot for taking care of this! I reviewed mostly the changelog, since the actual diff is a bit too much...

  • added 1 commit

    Compare with previous version

  • Robbert Krebbers added 6 commits

    added 6 commits

    • b7eaaf91 - Follow same scheme for other map lemmas.
    • f85c45f4 - Follow same scheme for `multiplicity_singleton`.
    • 211ee09d - Follow same scheme for list lemmas.
    • f0787262 - CHANGELOG.
    • 23b17486 - Improvements to CHANGELOG.
    • 59b232a3 - Improvements to CHANGELOG.

    Compare with previous version

  • Robbert Krebbers mentioned in merge request !532

    mentioned in merge request !532

  • Robbert Krebbers changed target branch from master to ci/refactor_staging

    changed target branch from master to ci/refactor_staging

  • I changed this MR to be merged in the the "refactor" staging branch (see !532). Aside from the CHANGELOG discussion, I think this one is good to go.

    Edited by Robbert Krebbers
  • Ralf Jung resolved all threads

    resolved all threads

  • Ralf Jung
  • Robbert Krebbers added 2 commits

    added 2 commits

    Compare with previous version

  • Ralf Jung
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading