Skip to content
Snippets Groups Projects

Set `simpl never` for `Pos` and `N`.

Merged Robbert Krebbers requested to merge robbert/simpl_never_pos_n into master

Previously, we set simpl never for just Pos.mul and N.add. That's pretty inconsistent and annoying. For example:

Eval simpl in (2 + x)%positive.
(*
     = match x with
       | q~1 => match q with
                | q0~1 => (Pos.succ q0)~0
                | q0~0 => q0~1
                | 1 => 2
                end~1
       | q~0 => match q with
                | q0~1 => (Pos.succ q0)~0
                | q0~0 => q0~1
                | 1 => 2
                end~0
       | 1 => 3
       end
     : positive
*)

I copied the list of simpl never declarations for Z and removed the operations (e.g., opp) that are not available for N or Pos.

Edited by Robbert Krebbers

Merge request reports

Merge request pipeline #81611 passed

Merge request pipeline passed for 82da9f06

Approval is optional

Merged by Robbert KrebbersRobbert Krebbers 2 years ago (May 1, 2023 6:28am UTC)

Merge details

  • Changes merged into with 2f90d657.
  • Deleted the source branch.

Pipeline #81612 passed

Pipeline passed for 2f90d657 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
Please register or sign in to reply
Loading