Skip to content
Snippets Groups Projects

Add locality for `Hint Rewrite`.

Merged Robbert Krebbers requested to merge robbert/hint_rewrite_locality into master
All threads resolved!

We can do this since we dropped support for Coq 8.13.

For natmap, the apply to internal lemmas and should thus be Local.

For the bit files, it appears the rewrites are used in a tactic that is used externally. Hence they should be Global.

Merge request reports

Merge request pipeline #77790 passed

Merge request pipeline passed for 7993266d

Approval is optional

Merged by Robbert KrebbersRobbert Krebbers 2 years ago (Feb 13, 2023 10:16pm UTC)

Loading

Pipeline #77793 passed

Pipeline passed for 46e72edb on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ralf Jung added 1 commit

    added 1 commit

    • 7993266d - coq-lint: warn about Hint Rewrite without locality

    Compare with previous version

  • LGTM. I extended coq-lint to also complain about Hint Rewrite with missing locality.

  • Robbert Krebbers resolved all threads

    resolved all threads

  • mentioned in commit 46e72edb

  • Great. Merging.

  • Please register or sign in to reply
    Loading