Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • S stdpp
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 81
    • Issues 81
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Iris
  • stdpp
  • Merge requests
  • !424

Prevent [finite_countable] from solving unrelated evars

  • Review changes

  • Download
  • Email patches
  • Plain diff
Open Paolo G. Giarrusso requested to merge Blaisorblade/stdpp:fix-finite-countable into master Nov 24, 2022
  • Overview 6
  • Commits 1
  • Pipelines 2
  • Changes 2

Fix issue reported by @jung in https://mattermost.mpi-sws.org/iris/pl/dqsc96ndbinfbyi8m4iuptjchw. Fixes #160.

The problem is that Hint Immediate translates to (something like) simple apply @finite.finite_countable ; trivial in the trace, and one (or both) the tactics trigger https://github.com/coq/coq/issues/6583. So I've adapted Iris's work around; I've not confirmed whether all of it is needed, but it worked on first try.

Missing (I assume):

  • trivial only uses hints with cost 0, but typeclasses eauto 0 does not appear to work, so typeclasses eauto 1 is the closest thing I see. This might be a problem.
  • Testcase
  • Changelog? Probably not needed since this is a bugfix
  • Mention this in upstream issue.
Edited Mar 19, 2023 by Paolo G. Giarrusso
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix-finite-countable