Refactor and improve documentation of feed and efeed tactics
This MR is based on !389 (closed).
Discussion from !389 (comment 82974) :
The documentation does not even mention the
by
part of this tactic. Also,efeed tac H
(which is what the documentation uses in the first line) is not the correct syntax for this tactic. Maybefeed
should also be adjusted to be writtenfeed H using tac
? Actually 'using' is a strange verb here, it sounds liketac
is involved in the feeding, but that's not the case. Isto
a keyword already, i.e., can we useefeed H to tac
? Orinto
?
See also the discussion here: !389 (comment 82750)
@robbertkrebbers Please feel free to update this MR as you see fit.
Merge request reports
Activity
assigned to @msammler
mentioned in merge request !389 (closed)
- Resolved by Michael Sammler
- Resolved by Michael Sammler
- Resolved by Ralf Jung
- Resolved by Michael Sammler
Result of discussion with Robbert:
- The current naming scheme makes sense and it is preferable to have such a consistent naming scheme compared to having all kinds of tactics that all follow the same pattern but have different names.
- Splitting the MRs was a mistake and the other MR should be integrated into this one.
-
(e)feed
should be renamed to(e)feed_core
-
by
flag should be removed fromefeed
-
(e)feed revert
should be named(e)feed generalize
-
feed destruct
andefeed destruct
should be documented to be the same asdestruct
andedestruct
, but have them for consistency -
add a comment that
efeed generalize
isexploit
from CompCert -
add a comment that
efeed inversion
allows not just identifiers, unlikeinversion
Edited by Michael Sammleradded 1 commit
- 30220cd7 - Add the feed generalize, efeed generalize, efeed inversion, and efeed destruct tactics
added 1 commit
- c0225349 - Refactor feed and add the feed generalize, efeed generalize, efeed inversion,...
added 1 commit
- 94212f09 - Refactor feed and add the feed generalize, efeed generalize, efeed inversion,...
- Resolved by Ralf Jung
add a comment that
efeed generalize
isexploit
from CompCertThat sounds to be a key tactic then, might be good to have a usage example at least for this one.
- Resolved by Michael Sammler
added 19 commits
-
ff6c6c18...02fd8ca3 - 18 commits from branch
master
- d0eca127 - Refactor feed and add the feed generalize, efeed generalize, efeed inversion,...
-
ff6c6c18...02fd8ca3 - 18 commits from branch
added 1 commit
- 7662c360 - Refactor feed and add the feed generalize, efeed generalize, efeed inversion,...
added 1 commit
- 603bef84 - Refactor feed and add the feed generalize, efeed generalize, efeed inversion,...
- Resolved by Michael Sammler
- Resolved by Michael Sammler