Skip to content
Snippets Groups Projects

Annotate telescope notations to support literal telescope arguments.

Merged Janno requested to merge janno/fix-TargS-notation into master
All threads resolved!

!368 (merged) had the unfortunate consequence that literal telescope arguments would not typecheck any more. This MR fixes this by adding copious (but nonetheless minimal) amounts of casts and annotations to make the [tele_arg ..] notation work again. I added tests for both new and old unification.

I am currently running a full test with these changes on all BedRock proofs which should tell us a bit about the compatibility. I expect no problems here.

Something that is not reflected in the MR but is still interesting is that old unification, i.e. apply and friends, work even without the cast in the TargS notation. New unification, i.e. refine, does not. There might be a Coq bug to report here but I don't have time to dig into that right now.

Merge request reports

Merge request pipeline #65402 passed

Merge request pipeline passed for d1bec90c

Approval is optional

Merged by Ralf JungRalf Jung 3 years ago (May 4, 2022 12:00pm UTC)

Merge details

  • Changes merged into master with 1aceb4c6.
  • Deleted the source branch.

Pipeline #65437 passed

Pipeline passed for 1aceb4c6 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
    • Resolved by Ralf Jung

      Something that is not reflected in the MR but is still interesting is that old unification, i.e. apply and friends, work even without the cast in the TargS notation. New unification, i.e. refine, does not. There might be a Coq bug to report here but I don't have time to dig into that right now.

      Could you add that as a testcase, with comments explaining the situation?

  • Ralf Jung
  • Ralf Jung
  • Janno added 1 commit

    added 1 commit

    • d1bec90c - Document reasons for using both `exact` and `refine`.

    Compare with previous version

  • Ralf Jung resolved all threads

    resolved all threads

  • merged

  • Ralf Jung mentioned in commit 1aceb4c6

    mentioned in commit 1aceb4c6

  • Please register or sign in to reply
    Loading