Add is_closed_term tactic
This MR adds a tactic that has been proven quite useful in RefinedC. An example usecase can be found here: https://gitlab.mpi-sws.org/iris/stdpp/-/blob/4168f736be2fd735dc9680fda0a3b3a6af2b1b5e/theories/bitvector.v#L294 (There it is still called checked_closed).
Edited by Michael Sammler
Merge request reports
Activity
added 5 commits
-
7d8088c2...78b6bc41 - 4 commits from branch
master
- fb74bea1 - Add assert_closed tactic
-
7d8088c2...78b6bc41 - 4 commits from branch
- Resolved by Robbert Krebbers
Interesting. Some comments:
- I don't like the name. There's already Coq's
assert
tactic, and this one has nothing to do with that. Maybe something likeis_closed
oris_closed_term
would be better? - It would be good to explain in comments how this code works. The link to Zulip is nice for giving the initial author credit, but it would be better if the comments in the code are self-contained.
- I think there are some caveats. This tactic succeeds if the term depends on section variables, or axioms, or opaque terms. Is that correct? Can we do something about that?
- I don't like the name. There's already Coq's
added 5 commits
-
a757d4e3...ea36eb94 - 4 commits from branch
master
- 18280afe - Add is_closed_term tactic
-
a757d4e3...ea36eb94 - 4 commits from branch
- Resolved by Michael Sammler
- Resolved by Michael Sammler
- Resolved by Michael Sammler
- Resolved by Michael Sammler
- Resolved by Robbert Krebbers
- Resolved by Robbert Krebbers
Do you want to write a changelog entry?
added 9 commits
-
0088d876...9135fcfe - 8 commits from branch
master
- 5afe58c4 - Add is_closed_term tactic
-
0088d876...9135fcfe - 8 commits from branch
Please register or sign in to reply