Skip to content
Snippets Groups Projects

Mark set_size and set_fold as TC opaque

Merged Paolo G. Giarrusso requested to merge Blaisorblade/stdpp:finite_sets_2 into master
All threads resolved!

Updated according to suggestions.


Old title/description:

More TC opaqueness (appropriate???)

Take these as questions, and feel free to edit/close/... . Follow up from !328 (merged).

Edited by Paolo G. Giarrusso

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • @Blaisorblade I think adding the TC opaque declarations makes sense. I'm not so sure about the Params instance since it's not clear what's even the canonical Proper that we wish to declare as an instance (and hence, it's not clear what's the desired value for Params should be).

    Could you update this MR?

  • added 1 commit

    • e3157145 - Mark set_size and set_fold as TC opaque

    Compare with previous version

  • Paolo G. Giarrusso changed title from More TC opaqueness (appropriate???) to Mark set_size and set_fold as TC opaque

    changed title from More TC opaqueness (appropriate???) to Mark set_size and set_fold as TC opaque

  • Paolo G. Giarrusso changed the description

    changed the description

  • Paolo G. Giarrusso resolved all threads

    resolved all threads

  • Done; can you please merge? (No changelog, since !328 (merged) had none either).

  • Robbert Krebbers enabled an automatic merge when the pipeline for e3157145 succeeds

    enabled an automatic merge when the pipeline for e3157145 succeeds

  • Merging. Thanks!

  • mentioned in commit e9aae334

  • Please register or sign in to reply
    Loading