Skip to content
Snippets Groups Projects

More missing `Hint Mode`s.

Merged Robbert Krebbers requested to merge robbert/hintmode into master
All threads resolved!

This MR adds all the Hint Modes from @Blaisorblade's iris!696 (merged) to std++ with the exception of the controversial one for Equiv (see https://github.com/coq/coq/issues/14441), but including the ones for Sets.

Iris requires a one line fix, see iris!696 (comment 68611)

examples, reloc, iron, actris, and lambdarust all compile without changes.

I think we're still missing more Hint Modes, but I am not sure what's a proper way to detect them.

Merge request reports

Merge request pipeline #48070 passed

Merge request pipeline passed for c75cd874

Approval is optional

Merged by Robbert KrebbersRobbert Krebbers 4 years ago (Jun 4, 2021 11:10am UTC)

Merge details

  • Changes merged into master with aeb449a7.
  • Deleted the source branch.
  • Auto-merge enabled

Pipeline #48071 passed

Pipeline passed for aeb449a7 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • added 1 commit

    Compare with previous version

  • Robbert Krebbers resolved all threads

    resolved all threads

  • added 1 commit

    Compare with previous version

  • Robbert Krebbers enabled an automatic merge when the pipeline for c75cd874 succeeds

    enabled an automatic merge when the pipeline for c75cd874 succeeds

  • @iris-users This is a breaking change: you might need to add some additional type annotations to your development.

    Set `Hint Mode` for the classes `PartialOrder`, `TotalOrder`, `MRet`, `MBind`, `MJoin`, `FMap`, `OMap`, `MGuard`, `SemiSet`, `Set_`, `TopSet`, and `Infinite`.
  • mentioned in commit aeb449a7

  • Ralf Jung mentioned in merge request iris!696 (merged)

    mentioned in merge request iris!696 (merged)

  • Please register or sign in to reply
    Loading