Explicit visibility for Instances

Our existing check for this missed some cases:

• Existing Instance
• Program Instance
• Instance: (for anonymous instances)

Those are all detected now, so fix all the code accordingly.

added 1 commit

• c1248edd - also make sure Opaque/Transparent have visibility qualifiers

Compare with previous version

added 1 commit

• dbf8e7ae - show line numbers in errors

Compare with previous version

mentioned in merge request iris!684 (merged)

added 1 commit

• 03507275 - improve error message

Compare with previous version

added S-waiting-for-review label

mentioned in commit cb1daa49

added 9 commits

• 03507275...cb1daa49 - 3 commits from branch master
• d0183a61 - fix warnings about implicitly Global Instance
• 6c010757 - make local instances explicit
• 56001965 - also make sure Opaque/Transparent have visibility qualifiers
• 531fe4dd - show line numbers in errors
• eb035887 - improve error message
• 89ebe23f - Local Instance → Definition

Compare with previous version

resolved all threads

Forgot to say, modulo my comments LGTM!

enabled an automatic merge when the pipeline for 89ebe23f succeeds

mentioned in commit 54d7f380

merged