Skip to content
Snippets Groups Projects

Random collection of lemmas from RefinedC

Closed Michael Sammler requested to merge msammler/misc_upstream into master
4 unresolved threads

These are some things from RefinedC that I would like to upstream to stdpp. There are still some open questions, see the comments for them. Please let me know which of these changes make sense in stdpp.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
127 127 Existing Class TCTrue.
128 128 Existing Instance TCTrue_intro.
129 129
130 Inductive TCFalse : Prop :=.
131 Existing Class TCFalse.
132
133 Notation TCUnless P := (TCIf P TCFalse TCTrue).
  • Please add a comment to explain the intuition for this one.

    PS: Why do we need TCFalse at all? Cannot we just put False there? The point is that TC search should fail, and it will fail as badly on TCFalse as it would fail on False.

  • Please register or sign in to reply
  • 148 153 Global Hint Mode TCForall2 ! ! ! ! - : typeclass_instances.
    149 154 Global Hint Mode TCForall2 ! ! ! - ! : typeclass_instances.
    150 155
    156 Inductive TCExists {A} (P : A Prop) : list A Prop :=
    157 | TCExists_cons_hd x l : P x TCExists P (x :: l)
    158 | TCExists_cons_tl x l: TCExists P l TCExists P (x :: l).
  • 4320 4320 Lemma TCForall2_Forall2 {A B} (P : A B Prop) xs ys : TCForall2 P xs ys Forall2 P xs ys.
    4321 4321 Proof. split; induction 1; constructor; auto. Qed.
    4322 4322
    4323 Lemma TCExists_Exists {A} (P : A Prop) l :
    4324 TCExists P l Exists P l.
  • Thanks for the MR. I think it would be better if you could split this up into several MRs:

    1. For the Type classes
    2. For the tactic
    3. For the finmap stuff
    4. For the integers

    Then it's also better logged what features have been added by whom :)

  • Michael Sammler mentioned in merge request !246 (merged)

    mentioned in merge request !246 (merged)

  • Michael Sammler mentioned in merge request !247 (merged)

    mentioned in merge request !247 (merged)

  • Michael Sammler mentioned in merge request !248 (merged)

    mentioned in merge request !248 (merged)

  • Closing this MR as there are now individual MRs.

  • Michael Sammler mentioned in merge request !249 (merged)

    mentioned in merge request !249 (merged)

  • Please register or sign in to reply
    Loading