rename elem_of_equiv_L -> set_eq, and set_equiv_spec_L -> set_eq_subseteq
This hopefully makes the lemmas easier to find.
Merge request reports
Activity
- Resolved by Robbert Krebbers
mapset_eq
is an internal lemma, that should not be used. The lemma that you want iselem_of_equiv_L
. That said, that lemma is not easy to find...
added 19 commits
-
ae119f28...c5676b11 - 18 commits from branch
master
- 6c8f86aa - rename elem_of_equiv_L -> set_eq, and set_equiv_spec_L -> set_eq_subseteq
-
ae119f28...c5676b11 - 18 commits from branch
added 1 commit
- 88815fc7 - rename elem_of_equiv -> set_equiv and set_equiv_spec -> set_equiv_subseteq,...
added 31 commits
-
88815fc7...1f7d13f3 - 29 commits from branch
master
- cb566d43 - rename elem_of_equiv_L -> set_eq, and set_equiv_spec_L -> set_eq_subseteq
- ea3cdadb - rename elem_of_equiv -> set_equiv and set_equiv_spec -> set_equiv_subseteq,...
-
88815fc7...1f7d13f3 - 29 commits from branch
added 1 commit
- 4cb9449b - rename elem_of_equiv -> set_equiv and set_equiv_spec -> set_equiv_subseteq,...
@robbertkrebbers I think this is ready to be merged.
- Resolved by Robbert Krebbers
Related to the
set_{eq,equiv}_subseteq
lemmas, there's also https://gitlab.mpi-sws.org/iris/iris/-/blob/master/iris/bi/interface.v#L281Can we come up with some scheme to also make the naming of that lemma consistent?
We decided there are 4 renames we should do based in naming schemes we uncovered in this MR:
-
Rename
equiv_spec
in Iris iris!628 (merged) -
Forall_Forall2
should get a_diag
!223 (merged) -
The
_11
/_12
lemmas should be renamed to_1_1
/_1_2
. !222 (merged) -
We should add
_instance
suffixes to some TC instnaces to make room for using e.g.frac_op
as a lemma name, and document this. iris!629 (merged)
Edited by Robbert Krebbers-
Rename
mentioned in merge request iris!628 (merged)
added 9 commits
-
4cb9449b...889d99ae - 8 commits from branch
master
- 609a8918 - rename elem_of_equiv -> set_equiv and set_equiv_spec -> set_equiv_subseteq,...
-
4cb9449b...889d99ae - 8 commits from branch
It seems like there are MRs for all remaining tasks. Feel free to merge this MR once you have time to update reverse dependencies.
Edited by Robbert Krebbersadded 7 commits
-
609a8918...c7f299a5 - 6 commits from branch
master
- 46cc81ad - rename elem_of_equiv -> set_equiv and set_equiv_spec -> set_equiv_subseteq,...
-
609a8918...c7f299a5 - 6 commits from branch
mentioned in commit 58c0e8cb