Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • S stdpp
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 81
    • Issues 81
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 10
    • Merge requests 10
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Releases
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Iris
  • stdpp
  • Merge requests
  • !177

[simpl_map]: avoid using [rewrite .. by ..]

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Armaël Guéneau requested to merge Armael/stdpp:simpl_map into master Jul 20, 2020
  • Overview 4
  • Commits 1
  • Pipelines 0
  • Changes 1

We've been using a patched version of [simpl_map] in our project for a while, with the changes included here.

The core issue is that it seems that [rewrite .. by ..] is not available when explicitly importing ssreflect. The patch uses by tac instead, which is in line with what [simplify_map_eq] does later in the file.

I tried to write a quick test to demonstrate the issue; however it seems that triggering it is a bit subtle (while it does definitely occur on our development, I wasn't able to easily reproduce it on my synthetic example--- I think there is some interaction with the exact order of the Require Import invocations).

If deemed necessary I could try harder and try to minimize a problematic instance from our development.

Edited Sep 29, 2020 by Robbert Krebbers
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: simpl_map