Skip to content
Snippets Groups Projects

Added select and select_revert tactics

Merged Michael Sammler requested to merge msammler/select_tac into master

As discussed with @robbertkrebbers open points:

  • Names of the tactics (What are the names in Mtac? @janno )
  • Changelog entry?
Edited by Michael Sammler

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • The name in Mtac2 is select: https://github.com/Mtac2/Mtac2/blob/master/theories/tactics/Tactics.v#L737

    The tactic is a bit different, it returns the name of the hypothesis, instead of calling a continuation (which would backtrack in case of multiple matches).

    Edited by Robbert Krebbers
  • Do you think returning the name would be a better option here as well?

  • added 1 commit

    • 087d31c2 - Added select and select_revert tactics

    Compare with previous version

  • Robbert Krebbers resolved all threads

    resolved all threads

  • Ralf Jung
  • Michael Sammler marked the checklist item Names of the tactics (What are the names in Mtac? @janno ) as completed

    marked the checklist item Names of the tactics (What are the names in Mtac? @janno ) as completed

  • Michael Sammler marked the checklist item Changelog entry? as completed

    marked the checklist item Changelog entry? as completed

  • added 1 commit

    • bc565b4e - Added select and select_revert tactics

    Compare with previous version

  • added 1 commit

    • f9beb585 - Added select and select_revert tactics

    Compare with previous version

  • Ralf Jung
  • Ralf Jung
  • added 1 commit

    • 18113ce2 - Added select and select_revert tactics

    Compare with previous version

  • added 1 commit

    • e25a9be2 - Added select and select_revert tactics

    Compare with previous version

  • Ralf Jung resolved all threads

    resolved all threads

  • LGTM.

  • Michael Sammler added 13 commits

    added 13 commits

    Compare with previous version

  • added 1 commit

    • 92213810 - Added select and select_revert tactics

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading