Revise the theory of the monotone CMRA
In reference to #414 (closed): I just used monotone
, and I have some relevant suggestions with a concrete implementation.
I've also simplifies some proofs using set_solver
.
- Type inference sometimes prefers
principal_injN
overprincipal_inj_instance
(as shown by the included test), which hinders some proofs — that's easily fixed, butprincipal_injN
might warrant more revisions (see below). - Because of
CmraDiscrete (mraR R)
, maybe the theory aboutdist (A := mra R)
should be removed.- This MR removes almost all of this theory.
- I used the
mra_over_ofe
theory over aleibnizO
OFE, but that theory holds for an arbitrary relationS
overA
, as long asR
"respectsS
" in the right way — tying it to ofes seems potentially artificial.- Here I make such instances opt-in via
#[export]
; by default, I only export the theory relevant toS := (=)
, which is onlyprincipal_inj
.
- Here I make such instances opt-in via
Edited by Paolo G. Giarrusso
Merge request reports
Activity
Filter activity
cc @amintimany .
Thanks @Blaisorblade :-) These are all good suggestions. The code also looks good to me.
- Resolved by Robbert Krebbers
- Resolved by Robbert Krebbers
- Resolved by Robbert Krebbers
- Resolved by Robbert Krebbers
mentioned in issue #414 (closed)
- Resolved by Robbert Krebbers
added 34 commits
-
ce34fef3...95f3a05f - 26 commits from branch
iris:master
- 2ffdad74 - Test problem with monotone cmra
- 29c0b0ce - Some proof tweaks
- 1a528fbd - Theory revisions
- 2dd90962 - Replace some proofs with set_solver
- eae1b7ba - Make [mra_over_rel] an opt-in module
- 77bdb4c8 - Tweak `mra`.
- 5bc923f1 - Make `R` argument of `principle` implicit, it can be infered from the type of `mra R`.
- 5d4507f9 - Rename `monotone` into `mra`; move out of unstable.
Toggle commit list-
ce34fef3...95f3a05f - 26 commits from branch
Please register or sign in to reply