Skip to content
Snippets Groups Projects

Revise the theory of the monotone CMRA

Merged Paolo G. Giarrusso requested to merge Blaisorblade/iris:monotone-tweaks into master

In reference to #414 (closed): I just used monotone, and I have some relevant suggestions with a concrete implementation.

I've also simplifies some proofs using set_solver.

  • Type inference sometimes prefers principal_injN over principal_inj_instance (as shown by the included test), which hinders some proofs — that's easily fixed, but principal_injN might warrant more revisions (see below).
  • Because of CmraDiscrete (mraR R), maybe the theory about dist (A := mra R) should be removed.
    • This MR removes almost all of this theory.
  • I used the mra_over_ofe theory over a leibnizO OFE, but that theory holds for an arbitrary relation S over A, as long as R "respects S" in the right way — tying it to ofes seems potentially artificial.
    • Here I make such instances opt-in via #[export]; by default, I only export the theory relevant to S := (=), which is only principal_inj.
Edited by Paolo G. Giarrusso

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Ralf Jung
  • Ralf Jung
  • Ralf Jung
  • Thanks! Just some nits.

  • Ralf Jung mentioned in issue #414 (closed)

    mentioned in issue #414 (closed)

  • Ralf Jung
  • Overall, it seems Ralf agrees with me the current dist theory can be taken out even more completely, and that should help the next revision.

  • Robbert Krebbers added 34 commits

    added 34 commits

    • ce34fef3...95f3a05f - 26 commits from branch iris:master
    • 2ffdad74 - Test problem with monotone cmra
    • 29c0b0ce - Some proof tweaks
    • 1a528fbd - Theory revisions
    • 2dd90962 - Replace some proofs with set_solver
    • eae1b7ba - Make [mra_over_rel] an opt-in module
    • 77bdb4c8 - Tweak `mra`.
    • 5bc923f1 - Make `R` argument of `principle` implicit, it can be infered from the type of `mra R`.
    • 5d4507f9 - Rename `monotone` into `mra`; move out of unstable.

    Compare with previous version

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading