Skip to content
Snippets Groups Projects

Improve documentation of convention for `AsFractional` instances

Merged Improve documentation of convention for `AsFractional` instances
robbert/asfractional into master
All threads resolved!
Merged Robbert Krebbers requested to merge robbert/asfractional into master
All threads resolved!

See discussion at !737 (comment 75155)

@Blaisorblade and @jung please review.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Paolo G. Giarrusso
  • Paolo G. Giarrusso
    Paolo G. Giarrusso @Blaisorblade ·
    Contributor

    LGTM then.

  • Ralf Jung
    Ralf Jung @jung ·
    Owner

    The comment LGTM, but might be good to also have a brief reference to this in the big-op files (where the Fractional instances without accompanying AsFractional are).

  • Robbert Krebbers
    Robbert Krebbers @robbertkrebbers ·
    Author Owner

    Unless I'm missing some, they are in the fractional file, see https://gitlab.mpi-sws.org/iris/iris/-/blob/master/iris/bi/lib/fractional.v#L80

  • Ralf Jung
    Ralf Jung @jung ·
    Owner

    Oh, right, fractional is a lib but big-op is in 'core'.

    Yeah LGTM then!

  • Robbert Krebbers resolved all threads

    resolved all threads

  • Robbert Krebbers mentioned in commit 90b6007f

    mentioned in commit 90b6007f

  • Robbert Krebbers merged

    merged

    • Please register or sign in to reply