Skip to content
Snippets Groups Projects

Make `_iff` and `_alter` lemmas for invariants consistent, and add `_iff` lemma for locks

Merged Robbert Krebbers requested to merge robbert/lock_contractive into master
All threads resolved!

The _iff lemma and contractive instance for is_lock were missing. This MR adds these.

The _iff and _alter lemmas for invariants had their arguments in inconsistent order. This MR makes them consistent with e.g., wp_wand. For example, inv N P -∗ ▷ □ (P ↔ Q) -∗ inv N Q.

Edited by Robbert Krebbers

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Robbert Krebbers changed title from Make _iff and _alter lemmas for invariants consistent, and add such a lemma for locks to Make _iff and _alter lemmas for invariants consistent, and add {+_iff+} lemma for locks

    changed title from Make _iff and _alter lemmas for invariants consistent, and add such a lemma for locks to Make _iff and _alter lemmas for invariants consistent, and add {+_iff+} lemma for locks

  • Robbert Krebbers changed the description

    changed the description

  • Ralf Jung
  • Ralf Jung resolved all threads

    resolved all threads

  • LGTM.

    @iris-users this is a breaking change for cinv_iff, inv_alter, inv_iff, na_inv_iff.

    @robbertkrebbers maybe the changelog should list explicitly (for grepping purposes) which lemmas actually change here.

    Edited by Ralf Jung
  • Ralf Jung
  • Robbert Krebbers added 12 commits

    added 12 commits

    Compare with previous version

  • Robbert Krebbers resolved all threads

    resolved all threads

  • @robbertkrebbers maybe the changelog should list explicitly (for grepping purposes) which lemmas actually change here.

    Done.

  • Ah inv_alter did not change actually.

  • LGTM, feel free to merge.

  • mentioned in commit 0ccaa796

  • Please register or sign in to reply
    Loading