Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
I
Iris
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 122
    • Issues 122
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 18
    • Merge Requests 18
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Iris
  • Iris
  • Merge Requests
  • !345

Merged
Opened Dec 13, 2019 by Paolo G. Giarrusso@BlaisorbladeContributor

Clarify use of Require

  • Overview 15
  • Commits 1
  • Changes 1
  • This seemingly useless Require Import confused me quite a bit. In fact, the Import is a no-op, and what matters are the side-effects of the Require. Not the most important thing, but it'd be nice to clarify it one way or the other.

Feel free to drop the 2nd commit (with the comment) in case you consider that weird Coq behavior too obvious.

  • Right now, https://github.com/coq/coq/pull/10476 fixed some bugs with Import, where it sometimes re-exported code; this MR might help ensure that Iris does not rely on that bug.
Edited Jan 14, 2020 by Paolo G. Giarrusso
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Reference: iris/iris!345
Source branch: clarify-require