Skip to content
Snippets Groups Projects
Closed Pierre Roux requested to merge proux1/iris:coq_18014 into master
1 unresolved thread

This is an overlay to be merged synchronously with the upstream PR.

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • This is an overlay to be merged synchronously with the upstream PR.

    No that won't work. We can only land MRs that work with Coq 8.18 and 8.17.

    • Ah, fun, it's one of those printing changes. And it's hard to normalize away.

      I think the best way forward is to for now mark Coq 8.19 as "broken" for our reference file checks, so that the output differences will be ignored. Unfortunately this means we won't notice other regressions in the printed output. When 8.19 becomes stable we can then change the reference files to 8.19 and mark all older Coq versions as "broken".

      Edited by Ralf Jung
    • That does not sound great, but I don't think there's a reasonable alternative.

      Having printing output reference files for multiple Coq versions would be possible, but that's a huge hassle. Iris contributors that change tests need to compile with multiple Coq versions to update both .ref files.

    • Please register or sign in to reply
  • Ralf Jung mentioned in merge request !1011 (merged)

    mentioned in merge request !1011 (merged)

  • Superseded by !1011 (merged), so this should not be necessary any more.

  • closed

Please register or sign in to reply
Loading