This issue has remain unresolved for a while now, so I'll close this MR. Thanks for your contribution! However, I'm afraid we don't have the capaci...
@jihgfee do you still plan to get back to this? There are some review comments above.
Thanks! I left some comments, they apply to both files....
Please don't keep commented-out code around.
Please add some more comments explaining what is happening here... I think the point of this is just to implement the interface? It's confusing tha...
This should be called _fractional
-
a056e2e1 · Merge branch 'rocq19987' into 'master'
- ... and 1 more commit. Compare 52d636bc...a056e2e1
Gitlab can squash on merge.
Should I also squash?
It does solve the slow done
s (this is actually most of the time saved).
Yes, sealing bin_log_related
seems like the way to go....
These big lines with multiple chained tactics in first are quite hard to maintain. If you could change as above, that would be great.
iApply (interp_expr_bind' [FstCtx] [FstCtx])....
Digging a little bit on the constants involved, I guess you wanted me to seal envs_entails
, but it is already (partially) sealed. I ended up sealing ...