Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
C
clockwork
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
cld
ml
clockwork
Compare revisions
08f33da916cc4d63c2b511e20dda33458cd11df2 to 6365880f66d564029b1711cab3f6ca973ec04a8a
Compare revisions
Changes are shown as if the
source
revision was being merged into the
target
revision.
Learn more about comparing revisions.
Source
cld/ml/clockwork
Select target project
No results found
6365880f66d564029b1711cab3f6ca973ec04a8a
Select Git revision
Swap
Target
cld/ml/clockwork
Select target project
cld/ml/clockwork
1 result
08f33da916cc4d63c2b511e20dda33458cd11df2
Select Git revision
Show changes
Only incoming changes from source
Include changes to target since source was created
Compare
Commits on Source (2)
Update priority queue so that elements with the same priority will be dequeued in insertion order
· f8f26904
DEPRECATED (Jonathan Mace) (Use @JonathanMace instead)
authored
4 years ago
f8f26904
Bugfix NPE in task telemetry
· 6365880f
DEPRECATED (Jonathan Mace) (Use @JonathanMace instead)
authored
4 years ago
6365880f
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
src/clockwork/action.cpp
+24
-18
24 additions, 18 deletions
src/clockwork/action.cpp
src/clockwork/priority_queue.h
+6
-3
6 additions, 3 deletions
src/clockwork/priority_queue.h
with
30 additions
and
21 deletions
src/clockwork/action.cpp
View file @
6365880f
...
...
@@ -474,27 +474,33 @@ void InferAction::handle_error(TaskError &error) {
result
->
status
=
error
.
status_code
;
result
->
message
=
error
.
message
;
set_taskTelemetry
(
copy_input
->
telemetry
,
action
->
id
,
action
->
model_id
,
action
->
gpu_id
,
error
.
status_code
,
action
->
batch_size
,
copy_input_earliest
(),
workerapi
::
inferAction
,
copyInputTask
);
if
(
copy_input
!=
nullptr
)
{
set_taskTelemetry
(
copy_input
->
telemetry
,
action
->
id
,
action
->
model_id
,
action
->
gpu_id
,
error
.
status_code
,
action
->
batch_size
,
copy_input_earliest
(),
workerapi
::
inferAction
,
copyInputTask
);
runtime
->
task_telemetry_logger
->
log
(
copy_input
->
telemetry
);
}
set_taskTelemetry
(
exec
->
telemetry
,
action
->
id
,
action
->
model_id
,
action
->
gpu_id
,
error
.
status_code
,
action
->
batch_size
,
action
->
earliest
,
workerapi
::
inferAction
,
execTask
);
if
(
exec
!=
nullptr
)
{
set_taskTelemetry
(
exec
->
telemetry
,
action
->
id
,
action
->
model_id
,
action
->
gpu_id
,
error
.
status_code
,
action
->
batch_size
,
action
->
earliest
,
workerapi
::
inferAction
,
execTask
);
runtime
->
task_telemetry_logger
->
log
(
exec
->
telemetry
);
}
set_taskTelemetry
(
copy_output
->
telemetry
,
action
->
id
,
action
->
model_id
,
action
->
gpu_id
,
error
.
status_code
,
action
->
batch_size
,
action
->
earliest
,
workerapi
::
inferAction
,
copyOutputTask
);
if
(
copy_output
!=
nullptr
)
{
set_taskTelemetry
(
copy_output
->
telemetry
,
action
->
id
,
action
->
model_id
,
action
->
gpu_id
,
error
.
status_code
,
action
->
batch_size
,
action
->
earliest
,
workerapi
::
inferAction
,
copyOutputTask
);
runtime
->
task_telemetry_logger
->
log
(
copy_output
->
telemetry
);
}
runtime
->
task_telemetry_logger
->
log
(
copy_input
->
telemetry
);
runtime
->
task_telemetry_logger
->
log
(
exec
->
telemetry
);
runtime
->
task_telemetry_logger
->
log
(
copy_output
->
telemetry
);
this
->
error
(
result
);
}
...
...
This diff is collapsed.
Click to expand it.
src/clockwork/priority_queue.h
View file @
6365880f
...
...
@@ -18,12 +18,15 @@ private:
// TODO: priority should be a chrono timepoint not the uint64_t, to avoid
// expensive conversions. Or, a different clock altogether
uint64_t
priority
;
uint64_t
version
;
friend
bool
operator
<
(
const
container
&
lhs
,
const
container
&
rhs
)
{
return
lhs
.
priority
<
rhs
.
priority
;
return
lhs
.
priority
<
rhs
.
priority
||
(
lhs
.
priority
==
rhs
.
priority
&&
lhs
.
version
<
rhs
.
version
);
}
friend
bool
operator
>
(
const
container
&
lhs
,
const
container
&
rhs
)
{
return
lhs
.
priority
>
rhs
.
priority
;
return
lhs
.
priority
>
rhs
.
priority
||
(
lhs
.
priority
==
rhs
.
priority
&&
lhs
.
version
>
rhs
.
version
);
}
};
...
...
@@ -42,7 +45,7 @@ public:
// TODO: will have to convert priority to a chrono::timepoint
if
(
alive
)
{
queue
.
push
(
container
{
element
,
priority
});
queue
.
push
(
container
{
element
,
priority
,
version
});
version
++
;
}
...
...
This diff is collapsed.
Click to expand it.