Merge branch 'robbert/pretty_N_go_stackoverflow' into 'master'

Fix potential stack overflow related to `Pretty N`.

See merge request iris/stdpp!286

tests/pretty.v

 From stdpp Require Import pretty.
+From Coq Require Import Ascii.
 
 Section N.
   Local Open Scope N_scope.
@@ -17,6 +18,17 @@ Section N.
   Proof. reflexivity. Qed.
 End N.
 
+(** Minimized version of:
+
+  https://coq.zulipchat.com/#narrow/stream/237977-Coq-users/topic/Stack.20overflow.20in.20Qed.2E
+
+Fixed by making the [wp_guard] in [pretty_N_go] proportional to the
+size of the input so that it blocks in case the input is an open term. *)
+Lemma test_no_stack_overflow p n :
+  get n (pretty (N.pos p)) ≠ Some "_"%char →
+  get (S n) ("-" +:+ pretty (N.pos p)) ≠ Some "_"%char.
+Proof. intros Hlem. apply Hlem. Qed.
+
 Section nat.
   Local Open Scope nat_scope.
 

theories/pretty.v

@@ -22,8 +22,11 @@ Fixpoint pretty_N_go_help (x : N) (acc : Acc (<)%N x) (s : string) : string :=
      (String (pretty_N_char (x `mod` 10)) s)
   | right _ => s
   end.
+(** The argument [S (N.size_nat x)] of [wf_guard] makes sure that computation
+works if [x] is a closed term, but that it blocks if [x] is an open term. The
+latter prevents unexpected stack overflows, see [tests/pretty.v]. *)
 Definition pretty_N_go (x : N) : string → string :=
-  pretty_N_go_help x (wf_guard 32 N.lt_wf_0 x).
+  pretty_N_go_help x (wf_guard (S (N.size_nat x)) N.lt_wf_0 x).
 Global Instance pretty_N : Pretty N := λ x,
   if decide (x = 0)%N then "0" else pretty_N_go x "".