generalize into_and_sep_affine so that generalizing just the conjunction instance for IntoExist is sufficient

Tej Chajed authored 4 years ago and Ralf Jung committed 4 years ago

The syntax re-uses the existing support for pure names, namely the % and
%H patterns. Using "[% H]" is like `iDestruct ... as (?) "H"` and using
"[%x H]" (with the string-ident plugin) is like `iDestruct ... as (x)
"H"`.

This changes how these patterns are parsed. Previously, both would have
been handled as conjunctions (using IntoAnd or IntoSep, depending on
whether the hypothesis is persistent or not). This means it was possible
for the user to use "[% H]" to destruct a pure hypothesis ⌜φ ∧ ψ⌝ and
put only the first conjunct in the Gallina context, leaving the other
one in the IPM; such patterns will now break, since iExistDestruct
does not handle this use case.

Tej Chajed authored 4 years ago and Ralf Jung committed 4 years ago

Fixes #404

Hence, also rename (the old) `equiv_entails` → `equiv_entails_1_1` and
`equiv_entails_sym` → `equiv_entails_1_2`, and add `equiv_entails_2` for completeness.

Done with a script by Tej; see
iris/iris!609 for details.

This makes sure that when trying to open an invariant or to eliminate a mask-changing
update around a non-atomic WP that it doesn't fail with "cannot eliminate modality",
but instead gives an side-condition `Atomic ...` informing the user what's going on.

Unlike the class `ElimModal` and `ElimInv`, the class `ElimAcc` was not yet equipped
with a Coq side-condition. This commit adds such a side-condition.

This is an alternative to !591.

Fixes new Coq master warning deprecated-hint-without-locality
(https://github.com/coq/coq/pull/13188).

This reverts merge request !591

Tej Chajed authored 4 years ago and Robbert Krebbers committed 4 years ago

`iDestruct ("H" with "HP")` where "H" is persistent is supposed to
consume "H" if it isn't a forall. Due to a bug in the tactic, this
behavior was never triggered and "H" was always left alone.