Skip to content
Snippets Groups Projects

Naming conventions

Merged Sophie Quinton requested to merge naming-conventions into master

@bbb @sbozhko @mlesourd @fradet @xiaojie @monin

We added an extra layer of hierarchy to start filling in the model in the restructuring folder.

We have chosen and applied some renaming rules for sections, cf. arrival_sequence.v and sporadic.v. Basically, we also use Valid* in the same way, same for respects*.

We have added some definitions of the sporadic task model. Our next step will be to add the TDMA scheduling policy to try and incorporate the RTA for TDMA.

This is still in progress, but comments are welcome!

Edited by Björn Brandenburg

Merge request reports

Pipeline #17191 passed

Pipeline passed for 8045a633 on naming-conventions

Merged by Björn BrandenburgBjörn Brandenburg 5 years ago (Jun 5, 2019 5:39pm UTC)

Loading

Pipeline #17207 passed

Pipeline passed for 8045a633 on master

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Just to let you know, I'm very much interested in this, but won't be able to take a closer look until after the RTSS deadline.

    Just a quick comment — could you perhaps add a short Markdown README that spells out the naming convention? I'm not entirely sure I'm aware of all the nuances. Thanks!

  • I understand this is part of a larger effort that's still ongoing, but could you get the restructuring part in mergeable shape soon? It would be good to get the "shuffling of files" into master asap so that other efforts can continue in parallel. Otherwise, if we keep changing master in the meantime, it will be more difficult for you to rebase at a later point when you are ready to merge everything.

  • assigned to @bbb

  • Björn Brandenburg
  • Author Reporter

    Hi Björn,

    Maxime and I have a Prosa session scheduled for later today, we'll be in touch.

    Sophie

  • Maxime Lesourd added 1 commit

    added 1 commit

    • e78ce6cb - Delete redundant busy_interval file

    Compare with previous version

  • Maxime Lesourd added 1 commit

    added 1 commit

    • 4d5f2c77 - fix indentation in completion.v

    Compare with previous version

  • Maxime Lesourd added 1 commit

    added 1 commit

    • 4a142459 - move readme to restructuring root

    Compare with previous version

  • Maxime Lesourd added 1 commit

    added 1 commit

    • 653e4a80 - applied naming convention to behavior

    Compare with previous version

  • Maxime Lesourd added 1 commit

    added 1 commit

    • a54bc566 - copied everything from model/policy_tdma.v

    Compare with previous version

  • Maxime Lesourd added 1 commit

    added 1 commit

    • 80b790b9 - Copied model/schedule/uni/basic/platform_tdma.v to restructuring/model/schedule/tdma.v

    Compare with previous version

  • We now have the definitions related to the TDMA scheduling policy ported to the restructuring part.

    We have tried a different approach for the "facts" related to TDMA by putting them in a file in the same directory as tdma.v.

    If everyone is okay with the current state of the branch I think we can merge this.

  • Björn Brandenburg resolved all discussions

    resolved all discussions

  • Björn Brandenburg unmarked as a Work In Progress

    unmarked as a Work In Progress

  • added 15 commits

    • 4e450bb1 - 1 commit from branch master
    • ac7533aa - Renaming in arrival_sequence.v
    • 84f10d7c - Moved sequential to schedule
    • 236580c8 - Renaming in schedule.v
    • fd740c34 - Renaming in arrival_sequence.v
    • 9f0dd5f2 - Indentation in facts
    • a4b526c4 - Moved behavior to restructuring/behavior
    • 2dbb1a72 - move job_cost to job.v
    • 3a3835f7 - add task_cost containing definitions related to the WCET model
    • de1c5695 - Add sporadic task model
    • 9a74f070 - fix indentation in completion.v
    • bc953db1 - move readme to restructuring root
    • 55c27c4f - applied naming convention to behavior
    • 82850eac - copied everything from model/policy_tdma.v
    • 2267dfb2 - Copied model/schedule/uni/basic/platform_tdma.v to restructuring/model/schedule/tdma.v

    Compare with previous version

  • (Rebased the branch in preparation of the merge.)

  • added 15 commits

    • 82454601 - 1 commit from branch master
    • a03c73df - Renaming in arrival_sequence.v
    • 7a9c7cbf - Moved sequential to schedule
    • d72908b6 - Renaming in schedule.v
    • 73ea8320 - Renaming in arrival_sequence.v
    • edaa526b - Indentation in facts
    • 1e4bc527 - Moved behavior to restructuring/behavior
    • 41717e83 - move job_cost to job.v
    • 848b0214 - add task_cost containing definitions related to the WCET model
    • 4e4337d6 - Add sporadic task model
    • ce517674 - fix indentation in completion.v
    • 557ced9d - move readme to restructuring root
    • 45853287 - applied naming convention to behavior
    • c68e8cb0 - copied everything from model/policy_tdma.v
    • 8045a633 - Copied model/schedule/uni/basic/platform_tdma.v to restructuring/model/schedule/tdma.v

    Compare with previous version

  • Sergey Bozhko resolved all discussions

    resolved all discussions

  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Loading
  • Please register or sign in to reply
    Loading