1. 29 Mar, 2019 1 commit
  2. 21 Feb, 2019 1 commit
  3. 20 Feb, 2019 1 commit
  4. 03 Feb, 2019 1 commit
  5. 24 Jan, 2019 1 commit
  6. 12 Dec, 2018 1 commit
  7. 01 Nov, 2018 1 commit
  8. 31 Oct, 2018 2 commits
  9. 15 Jun, 2018 3 commits
  10. 14 Jun, 2018 1 commit
  11. 05 Jun, 2018 1 commit
  12. 29 May, 2018 1 commit
  13. 05 Apr, 2018 2 commits
  14. 21 Mar, 2018 1 commit
  15. 19 Mar, 2018 1 commit
  16. 04 Mar, 2018 1 commit
  17. 03 Mar, 2018 1 commit
  18. 04 Dec, 2017 2 commits
  19. 01 Nov, 2017 2 commits
  20. 30 Oct, 2017 7 commits
  21. 28 Oct, 2017 1 commit
  22. 26 Oct, 2017 1 commit
  23. 25 Oct, 2017 3 commits
  24. 21 Sep, 2017 1 commit
  25. 17 Sep, 2017 1 commit
  26. 24 Mar, 2017 1 commit
    • Robbert Krebbers's avatar
      Make big_opL type class opaque. · 02a0929d
      Robbert Krebbers authored
      This commit fixes the issues that refolding of big operators did not work nicely
      in the proof mode, e.g., given:
      
          Goal forall M (P : nat → uPred M) l,
            ([∗ list] x ∈ 10 :: l, P x) -∗ True.
          Proof. iIntros (M P l) "[H1 H2]".
      
      We got:
      
          "H1" : P 10
          "H2" : (fix
                  big_opL (M0 : ofeT) (o : M0 → M0 → M0) (H : Monoid o) (A : Type)
                          (f : nat → A → M0) (xs : list A) {struct xs} : M0 :=
                    match xs with
                    | [] => monoid_unit
                    | x :: xs0 => o (f 0 x) (big_opL M0 o H A (λ n : nat, f (S n)) xs0)
                    end) (uPredC M) uPred_sep uPred.uPred_sep_monoid nat
                   (λ _ x : nat, P x) l
          --------------------------------------∗
          True
      
      The problem here is that proof mode looked for an instance of `IntoAnd` for
      `[∗ list] x ∈ 10 :: l, P x` and then applies the instance for separating conjunction
      without folding back the fixpoint. This problem is not specific to the Iris proof
      mode, but more of a general problem of Coq's `apply`, for example:
      
          Goal forall x l, Forall (fun _ => True) (map S (x :: l)).
          Proof.
            intros x l. constructor.
      
      Gives:
      
           Forall (λ _ : nat, True)
             ((fix map (l0 : list nat) : list nat :=
                match l0 with
                | [] => []
                | a :: t => S a :: map t
                end) l)
      
      This commit fixes this issue by making the big operators type class opaque and instead
      handle them solely via corresponding type classes instances for the proof mode tactics.
      
      Furthermore, note that we already had instances for persistence and timelessness. Those
      were really needed; computation did not help to establish persistence when the list in
      question was not a ground term. In fact, the sitation was worse, to establish persistence
      of `[∗ list] x ∈ 10 :: l, P x` it could either use the persistence instance of big ops
      directly, or use the persistency instance for `∗` first. Worst case, this can lead to an
      exponential blow up because of back tracking.
      02a0929d