Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
I
Iris
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 122
    • Issues 122
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 15
    • Merge Requests 15
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Analytics
    • Analytics
    • CI/CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • Iris
  • Iris
  • Merge Requests
  • !558

Merged
Created Oct 30, 2020 by Ralf Jung@jungOwner

use Qp inequality instead of frac validity for lemma statements

  • Overview 40
  • Commits 2
  • Changes 15

Many lemma statements use ✓ q instead of (q ≤ 1)%Qp to express validity of a fraction. There was no ≤ on Qp before Robbert's recent changes, so this makes sense historically. It is also true that ✓ q is shorter, but it is rather cryptic, and usually the user will think in terms of inequalities and not validity of fractions.

So with this MR I propose we change all these lemma statements to use inequality instead. I used rg '✓[^↔→⊢]*%Qp|✓[ {}n]*[qp]' to find the lemmas that would need changing from this; I hope I did not miss any. The one thing I did not change is the definition of validity of view, but I am happy to also change that if people prefer.

We should also avoid using ⋅ for Qp addition and ≼ for ≤, but I could not find any instances of that.

Edited Nov 05, 2020 by Ralf Jung
Assignee
Assign to
Reviewer
Request review from
None
Milestone
None
Assign milestone
Time tracking
Source branch: ralf/frac-valid